Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PT unit is always shown as SUV even when the value is not in SUV (because meta data is missing) #163

Closed
pwespi opened this issue Aug 4, 2022 · 3 comments

Comments

@pwespi
Copy link
Contributor

pwespi commented Aug 4, 2022

Currently the annotations (elliptical, rectangle, probe, maybe others) show SUV as the unit of all PT images (see .e.g. https://github.com/cornerstonejs/cornerstone3D-beta/blob/main/packages/tools/src/tools/annotation/RectangleROITool.ts#L851-L854).

However, not all PT images have the required metadata to convert values to SUV.

https://v3-demo.ohif.org/viewer?StudyInstanceUIDs=1.3.6.1.4.1.25403.345050719074.3824.20170125113417.1
Screenshot 2022-08-04 at 09 54 51
If you inspect the log, you can find:

Error: CorrectedImage must contain "ATTN" and "DECY": NORM,DTIM,RADL,DECY
    at calculateSUVScalingFactors

Error: PatientWeight value is missing. It is not possible to calculate the SUV factors

So in these cases the unit should not be SUV.

Ideally, even if all metadata is present to calculate SUV, the user should be able to select the unit (e.g. if an image is in units Bq/ml, that might be what the user actually wants so see).

PS: Thank you for this great library!

@pwespi
Copy link
Contributor Author

pwespi commented Aug 4, 2022

Before changing any of this, it might make sense to unify the handling of units, see #161

@pwespi
Copy link
Contributor Author

pwespi commented Aug 4, 2022

I'm wondering if the cornerstone tools library is actually the right place to determine the units, since the actual metadata to convert the values is extracted in a different place, e.g. in a OHIF extension.

@pwespi
Copy link
Contributor Author

pwespi commented Aug 10, 2022

closed by #161

@pwespi pwespi closed this as completed Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant