Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replaceAll not found #67

Closed
sedghi opened this issue Apr 4, 2022 · 2 comments
Closed

replaceAll not found #67

sedghi opened this issue Apr 4, 2022 · 2 comments
Assignees
@wayfarer3130

Comments

@sedghi
Copy link
Member

sedghi commented Apr 4, 2022

Running examples give error since replaceAll is only supported in node > 15.

return str.replaceAll('\\', '/');
             ^

TypeError: str.replaceAll is not a function

@wayfarer3130 Can you please fix this for node > 12 which is the current dependency of the library?
@sedghi
Copy link
Member Author

sedghi commented Apr 4, 2022

https://nodejs.org/en/about/releases/

12 Seems to be outdated Erik mentioned, maybe we need to do 16 LTS

@swederik
Copy link
Member

swederik commented Apr 4, 2022

Should be fixed now. Thanks @wayfarer3130 !

@swederik swederik closed this as completed Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wayfarer3130 wayfarer3130

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@swederik @sedghi @wayfarer3130