You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
add/remove/modified events should not have viewportId and renderingEngineId as their event details. There are only one place that we depend on these Ids (at the onAnnotationModifiedListener where we trigger one last render for the viewports to update their text box since the cachedStats has been updated in a throttle).
I went ahead and removed all the unnecessary Ids but the rendering of annotations fails on the non acquisition planes. It appears
that triggerAnnotationForViewportIds is run for each viewports separately (assuming pt/ct layout, and annotating on ctAxial, it runs for ctAxial, ptAxial, fusionAxial separately), but the implemented approach was to trigger all in one, which failed.
Needs more investigation as why.
Potential reasons:
async throttling doesn't invalidate other viewports from not running their cachedStats and becomes an infinite loop? @JamesAPetts
The text was updated successfully, but these errors were encountered:
sedghi
changed the title
BUG: add annotation should not accept element
add/remove/modified events for annotations should not include viewportId and renderingEngineId
Apr 14, 2022
add/remove/modified events should not have
viewportId
andrenderingEngineId
as their event details. There are only one place that we depend on these Ids (at theonAnnotationModifiedListener
where we trigger one last render for the viewports to update their text box since the cachedStats has been updated in a throttle).I went ahead and removed all the unnecessary Ids but the rendering of annotations fails on the non acquisition planes. It appears
that
triggerAnnotationForViewportIds
is run for each viewports separately (assuming pt/ct layout, and annotating on ctAxial, it runs for ctAxial, ptAxial, fusionAxial separately), but the implemented approach was to trigger all in one, which failed.Needs more investigation as why.
Potential reasons:
Branch to look is here
The text was updated successfully, but these errors were encountered: