Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add/remove/modified events for annotations should not include viewportId and renderingEngineId #77

Closed
sedghi opened this issue Apr 14, 2022 · 2 comments

Comments

@sedghi
Copy link
Member

sedghi commented Apr 14, 2022

add/remove/modified events should not have viewportId and renderingEngineId as their event details. There are only one place that we depend on these Ids (at the onAnnotationModifiedListener where we trigger one last render for the viewports to update their text box since the cachedStats has been updated in a throttle).

I went ahead and removed all the unnecessary Ids but the rendering of annotations fails on the non acquisition planes. It appears
that triggerAnnotationForViewportIds is run for each viewports separately (assuming pt/ct layout, and annotating on ctAxial, it runs for ctAxial, ptAxial, fusionAxial separately), but the implemented approach was to trigger all in one, which failed.

Needs more investigation as why.

Potential reasons:

  • async throttling doesn't invalidate other viewports from not running their cachedStats and becomes an infinite loop? @JamesAPetts

Branch to look is here

@sedghi sedghi changed the title BUG: add annotation should not accept element add/remove/modified events for annotations should not include viewportId and renderingEngineId Apr 14, 2022
@sedghi
Copy link
Member Author

sedghi commented Oct 13, 2023

@jbocce ditto

@sedghi
Copy link
Member Author

sedghi commented Oct 18, 2023

Although it would have been ideal not to begin with this, I am confident that no bugs will occur as a result. Therefore, it was not planned.

@sedghi sedghi closed this as completed Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant