Align typings on DataSet returns

[kmannislands]

Most methods on DataSet are typed incorrectly. For example, int16 declares that it will always return a number:

  export interface DataSet {
    /**
     * Finds the element for tag and returns an unsigned int 16 if it exists and has data. Use this function for VR type US.
     */
    uint16: (tag: string, index?: number) => number;
 
   // ...
}

However, the actual logic can also return undefined:

export default class DataSet {

  int16 (tag, index) {
    var element = this.elements[tag];

    index = (index !== undefined) ? index : 0;
    if (element && element.length !== 0) {
      return getByteArrayParser(element, this.byteArrayParser).readInt16(this.byteArray, element.dataOffset + (index * 2));
    }

    return undefined; // <- This part
  }

  // ...
}

I'd suggest updating the typing to reflect the implementation to avoid breaking changes (ie: returning 0 in this case)

[ohif-bot]

🎉 This issue has been resolved in version 1.8.14 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀