Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parseTM does not parse fractional seconds properly #75

Closed
nyej opened this issue Dec 5, 2017 · 0 comments
Closed

parseTM does not parse fractional seconds properly #75

nyej opened this issue Dec 5, 2017 · 0 comments
Assignees
Labels

Comments

@nyej
Copy link

nyej commented Dec 5, 2017

ParseTM parses out the fractional portion of the time stamp using a straight parseInt, causing '.5' and '.000005' to result in the same value of 5 microseconds. TM allows anywhere from 1 to 6 digits to be provided so parseTM needs to consider the actual number of digits present in the fractional component and multiply by the appropriate power of 10. Could also zero right-pad then parse but that would probably be the most expensive/wasteful option.

@swederik swederik added the bug label Mar 29, 2018
@swederik swederik assigned ayselafsar and unassigned galelis Mar 29, 2018
yagni added a commit to yagni/dicomParser that referenced this issue May 5, 2018
yagni added a commit to yagni/dicomParser that referenced this issue May 31, 2018
yagni added a commit to yagni/dicomParser that referenced this issue Sep 5, 2018
yagni added a commit to yagni/dicomParser that referenced this issue Sep 5, 2018
@yagni yagni closed this as completed in f239706 Nov 8, 2019
yagni added a commit that referenced this issue Nov 8, 2019
Fix #75 where parseTM did not properly calculate fractional seconds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants