Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Enhance Logging With Timber #24

Closed
Magoli1 opened this issue May 30, 2020 · 1 comment
Closed

Enhance Logging With Timber #24

Magoli1 opened this issue May 30, 2020 · 1 comment
Assignees
Labels
enhancement Improvement of an existing feature

Comments

@Magoli1
Copy link

Magoli1 commented May 30, 2020

Current Implementation

Currently the app uses the native android logging framework. To do that, every class holds a reference to a dedicated logging tag, which is given the logger, in case it is used. Example:

private val TAG: String? = ExposureStateUpdateReceiver::class.simpleName

Suggested Enhancement

There is a leightweight library called Timber, which automatically sets the logging tags to the calling class. We suggest to change the implementation for all logging calls towards Timber.

Expected Benefits

Timber optimizes the developer experience inseveral cases, eg. it automatically makes sure that the tag is at most 23 characters long (more details here). We could alsoget rid of the tag in every class that is currently hardcoded.

We would be happy if we could supply you with the corresponding PR 👍

Best Regards
Robert Jakobs & Tim Brüggenthies (@timbrueggenthies)

@Magoli1 Magoli1 added the enhancement Improvement of an existing feature label May 30, 2020
@tkowark tkowark added community Tag issues created by community members and removed community Tag issues created by community members labels May 31, 2020
@marcmuschko
Copy link
Contributor

Hi @Magoli1

Thank you for the suggestion! While this would provide some improvements on development side, it does not seem to introduce critical benefits. As every library included has to be thoroughly checked we add these kind of things very carefully after much consideration beforehand.
Therefore we will not be able to add the library at this point in time, and I'm closing the issue for now.

Nevertheless, thank you for the poposal!
Marc

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

3 participants