You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Currently the app uses the native android logging framework. To do that, every class holds a reference to a dedicated logging tag, which is given the logger, in case it is used. Example:
There is a leightweight library called Timber, which automatically sets the logging tags to the calling class. We suggest to change the implementation for all logging calls towards Timber.
Expected Benefits
Timber optimizes the developer experience inseveral cases, eg. it automatically makes sure that the tag is at most 23 characters long (more details here). We could alsoget rid of the tag in every class that is currently hardcoded.
We would be happy if we could supply you with the corresponding PR 👍
Thank you for the suggestion! While this would provide some improvements on development side, it does not seem to introduce critical benefits. As every library included has to be thoroughly checked we add these kind of things very carefully after much consideration beforehand.
Therefore we will not be able to add the library at this point in time, and I'm closing the issue for now.
Current Implementation
Currently the app uses the native android logging framework. To do that, every class holds a reference to a dedicated logging tag, which is given the logger, in case it is used. Example:
cwa-app-android/Corona-Warn-App/src/main/java/de/rki/coronawarnapp/receiver/ExposureStateUpdateReceiver.kt
Line 38 in 43412bd
Suggested Enhancement
There is a leightweight library called Timber, which automatically sets the logging tags to the calling class. We suggest to change the implementation for all logging calls towards Timber.
Expected Benefits
Timber optimizes the developer experience inseveral cases, eg. it automatically makes sure that the tag is at most 23 characters long (more details here). We could alsoget rid of the tag in every class that is currently hardcoded.
We would be happy if we could supply you with the corresponding PR 👍
Best Regards
Robert Jakobs & Tim Brüggenthies (@timbrueggenthies)
The text was updated successfully, but these errors were encountered: