Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Close button missing for RiskLegend #50

Closed
benekuehn opened this issue May 31, 2020 · 3 comments
Closed

Close button missing for RiskLegend #50

benekuehn opened this issue May 31, 2020 · 3 comments
Assignees
Labels
bug Something isn't working on hold

Comments

@benekuehn
Copy link

Describe the bug

The RiskLegend.storyboard is missing a button to dismiss the page sheet.

Expected behaviour

A close button in the top right corner, to over a button to close the sheet as stated in the development guidelines by apple.

People dismiss a card by:

  • Swiping down from the top of the screen
  • Swiping down from anywhere on the screen when card content is scrolled to the top
  • Tapping a button

Human Interface Guidelines – Modality

Steps to reproduce the issue

  1. Open the app
  2. Click on the information icon in the top right corner

Possible Fix

Include a close button in the top navigation bar on the RiskLegend page

@benekuehn benekuehn added the bug Something isn't working label May 31, 2020
@steins-code
Copy link
Member

Risk legend is only draft at the moment and will be completely reworked starting from tomorrow :)

@benekuehn
Copy link
Author

benekuehn commented May 31, 2020

@steins-code sorry, just saw your comment. Anyway, time for one more coffee tomorrow for the devs :)

@benekuehn
Copy link
Author

@EisvogelSAP can't this one be closed as the close button is now fixed?

@eisvogel eisvogel closed this as completed Jun 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working on hold
Projects
None yet
Development

No branches or pull requests

3 participants