Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Thank you and good luck for release day! #247

Closed
MikeJayDee opened this issue Jun 15, 2020 · 16 comments
Closed

Thank you and good luck for release day! #247

MikeJayDee opened this issue Jun 15, 2020 · 16 comments
Labels
documentation Improvements or additions to documentation enhancement Improvement of an existing feature

Comments

@MikeJayDee
Copy link

First, good luck for release day (which I understand is tomorrow)!

Secondly, thank you for all the hard work to everyone involved and for delivering on-time under a lot of pressure and under the watchful eye of the public.

Finally, against all pessimistic expectation, I wanted to thank you that this project is being developed in an absolutely exemplary and transparent manner. It is not only open source in name but also in spirit; I have never seen this before for a large publicly funded software project developed by a private corporation (at least in Germany).

So, again, thank you (and apologies for misusing an issue for this).

@MikeJayDee MikeJayDee added documentation Improvements or additions to documentation enhancement Improvement of an existing feature labels Jun 15, 2020
@SebastianWolf-SAP
Copy link
Member

Thank you very much for your kind words, really appreciated! And no problem with (mis)using an issue, we can even keep it open for a while... ;)

Let's keep our fingers crossed that it works out more or less as planned...

Mit freundlichen Grüßen/Best regards,
SW
Corona Warn-App Open Source Team

@NilsAhrDE
Copy link

When will the Download-Links be available today?

Thank you for your great work and happy release day!
Nils

@jonasohland
Copy link

I just installed the app from the Google Play Store. Looks like i am one of the first 10 users!
Thanks to everyone from the Corona Warn-App Open Source Team and all the contributors.
Happy tracing!

@daimpi
Copy link

daimpi commented Jun 16, 2020

Yes I also got it!
Thanks to everyone who is helping making this a success ☺️

Btw: here is the link to the landing page: https://www.corona-warn-app.de

@jakob11git
Copy link

Unfortunately only available in the German Apple App Store. Impossible to install without a German Apple ID.

@corneliusroemer
Copy link
Contributor

@jeifour Open a separate issue in the iOS app repo? For Android it might be possible to sideload in this case. Not sure whether there's a workaround for iOS

@lennarto
Copy link

@jeifour On your iPhone you are able to use more than one Apple ID per Device - Therefore I have a US-Apple ID as well as a german Apple ID to download specific apps.

@SebastianWolf-SAP SebastianWolf-SAP pinned this issue Jun 16, 2020
@sventuerpe
Copy link

Judging by the media echo the release seems to have gone well. Congratulations to everyone!

Like @MikeJayDee I am thoroughly impressed by the professionalism seen in this project, the constructive discussions around here, and timely delivery of the app. I would love to see more projects like* this in the future. Great job!

*) perhaps with a looser schedule and more flexible requirements

@KaiRoesner
Copy link

@sventuerpe , maybe the tight schedule and requirements were the reason why this went so well... ;-)

@sventuerpe
Copy link

@KaiRoesner A clearly defined mission and scope certainly helps and a short project can work at a speed that would be infeasible to sustain over a longer period.

@corneliusroemer
Copy link
Contributor

corneliusroemer commented Jun 18, 2020

While it is certainly laudable, that the release went more or less well, it's important to remember that there are important issues that remain to be resolved:

@Giszmo
Copy link

Giszmo commented Jun 18, 2020

* Build pushed cannot be confirmed to be authentic since reproducible build not provided, the APKs are also not published on Github #14 [corona-warn-app/cwa-app-android#514](https://github.com/corona-warn-app/cwa-app-android/issues/514)

Providing an alternative download on GitHub would not help as you want to know they roll out via Google what they show you and as they could in theory roll out a different version by country (not in this case as Google only allows one Corona app per country), by Phone model and even by user ID, you really want to collect the binaries where they end up, on the users' phones. If there is interest, I would extend this app to also monitor the corona app. Some 20 people using it would be awesome. No need for thousands or millions to run it. As I'm in Chile myself, I would have real difficulties to get the app by other means at all.

Regarding the reproducibility ... did you try to compile it? If the devs did everything right, it might "just work". The people at Google usually care a lot if some build tool or library doesn't produce deterministic results.

@corneliusroemer
Copy link
Contributor

@Giszmo Unfortunately the things you suggest don't work due to special whitelisting being necessary for a compiled app to be allowed to use the Exposure API #214

Published official apks would avoid people having to trust others, they just need to trust the developers, not Google nor mirror servers. Furthermore, Play Store APKs could be verified with checksums.

The app is currently rolled out as one apk containing all the various processor architecture apks, this is a reason for the large size of the app.

@Giszmo
Copy link

Giszmo commented Jun 18, 2020

@Giszmo Unfortunately the things you suggest don't work due to special whitelisting being necessary for a compiled app to be allowed to use the Exposure API #214

Reproducibility and testability are two different things. To test the reproducibility I don't need access to the exposure API.

Published official apks would avoid people having to trust others, they just need to trust the developers, not Google nor mirror servers. Furthermore, Play Store APKs could be verified with checksums.

What do you think a checksum would provide? Compute the checksum. My project does that for many apps with every update they release.

The app is currently rolled out as one apk containing all the various processor architecture apks, this is a reason for the large size of the app.

So? Reproducibility doesn't care about what you pack into your apk. In fact it's easier to reproduce one app than to reproduce 5 flavors of the same app.

Furthermore while it would be great if the app could be used from a binary compiled by any third party, reproducibility would actually mean that you could test the app from what you compiled:

  1. Take the original app
  2. Take the source code
  3. Compile the source code
  4. Add the signature from the original app to your result.
  5. If the app is reproducible, the signature will match and you can actually test it too. If not, then it's neither reproducible nor testable.

@corneliusroemer
Copy link
Contributor

@Giszmo May I suggest this discussion be moved to a more appropriate issue? Why don't you create one suggesting an implementation of your proposal?

@tkowark
Copy link
Member

tkowark commented Jul 16, 2020

Thank you very much again for all your support, questions, and also criticism throughout the last weeks!

@tkowark tkowark closed this as completed Jul 16, 2020
@tkowark tkowark unpinned this issue Jul 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests