Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Exposure configuration parameters not validated #122

Closed
michael-burwig opened this issue May 16, 2020 · 0 comments · Fixed by #260
Closed

Exposure configuration parameters not validated #122

michael-burwig opened this issue May 16, 2020 · 0 comments · Fixed by #260
Assignees
Labels
bug Something isn't working distribution service

Comments

@michael-burwig
Copy link
Member

michael-burwig commented May 16, 2020

The exposure configuration parameters are currently not validated after being read from the respective yml file. The validation code in ExposureConfigurationValidator is currently used in tests only.

However, the expected behavior shall be the following:

  • The RiskScoreParameters object is constructed based on yml file. (✅)
  • ExposureConfigurationValidator performs validation of the parameters.
  • In case of a failed validation, do not publish the exposure configuration parameters, but do generate and publish the diagnosis key bundles.
  • Clarify whether to keep any previously present (valid) configuration parameters on the object store if a validation error occurs.
  • Any validation errors shall be logged appropriately.
@michael-burwig michael-burwig added bug Something isn't working distribution service labels May 16, 2020
@johanneseschrig johanneseschrig added community This item is well suited to be worked on by the community. and removed community This item is well suited to be worked on by the community. labels May 21, 2020
@michael-burwig michael-burwig self-assigned this May 22, 2020
@michael-burwig michael-burwig linked a pull request May 22, 2020 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working distribution service
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants