Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Consider adding "/country/{{country}}" to submission endpoint #139

Closed
pithumke opened this issue May 17, 2020 · 2 comments
Closed

Consider adding "/country/{{country}}" to submission endpoint #139

pithumke opened this issue May 17, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@pithumke
Copy link
Member

pithumke commented May 17, 2020

Current Implementation

Submission endpoint is /version/{{version}}/diagnosis-keys

Suggested Enhancement

Change submission endpoint to /version/{{version}}/diagnosis-keys/country/{{country}}.

Expected Benefits

At the moment we can not be 100% certain that we will never have to submit diagnosis keys to other countries. However, if we ever get that requirement, and needed to introduce a country differentiating parameter, this would be a breaking change and would force us to bump the overall API version. With the proposed change (and an initial implementation for only /version/v1/diagnosis-keys/country/DE), this issue can already be avoided. Also, the proposed change would align the submission and distribution APIs.

@pithumke pithumke added the enhancement New feature or request label May 17, 2020
@christian-kirschnick
Copy link
Member

There are rumours that Google/Apple will also spec the submission data, so let's wait until they publish their aligned protocol. It will most certainly also consider the country information.

@christian-kirschnick christian-kirschnick added this to the Future Release milestone May 26, 2020
@christian-kirschnick
Copy link
Member

This topic will be dealt with in the Federation/Roaming scenario. Current plan is to have a list of countries in the submission payload in order to indicate for which countries the keys are of interest.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants