Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Android api 33 #593

Merged
merged 5 commits into from
Aug 18, 2023
Merged

Conversation

scottrules44
Copy link
Contributor

No description provided.

@Shchvova
Copy link
Contributor

Oh cool. I am working on this too. You migrated to android build plugin v7. Does packaging still works for you?

@scottrules44
Copy link
Contributor Author

Yes was able to make a test app from Android Studio, I have not tested packaging into Corona Sim and building with Sim. But can give it a try :)

@Shchvova
Copy link
Contributor

Shchvova commented Jul 22, 2023

Make sure to including assets like images and sounds.

@scottrules44
Copy link
Contributor Author

Just tested with 'AudioPlayer' demo and does include graphics and music

@scottrules44
Copy link
Contributor Author

'NativeDisplayObjects' demo seems to work as well, I also did test back button as well and seems to work normally with Android 13

@Shchvova
Copy link
Contributor

I will go through test cases and merge this on the week. If you want to help with testing even more consider trying out push notifications.

@scottrules44
Copy link
Contributor Author

I will go through test cases and merge this on the week. If you want to help with testing even more consider trying out push notifications.

Will do!

@scottrules44
Copy link
Contributor Author

I made some tweaks and bumped up Java to 11, I tried on my sim and ran into issue build issue unless I bump java to 11,
https://github.com/scottrules44/Solar2D-98/releases/tag/1069
(had to manually add Skins and 'Device Support' to allow for send to device from Current 3691)

But was able to build basic shape tumbler sample, will try some plugins (and other samples) to make sure there are no issue.

@scottrules44
Copy link
Contributor Author

The Local Notification Demo works (Tested with my custom Corona Sim)

We will have to tweak the plugin to request include the new permission

`timer.performWithDelay(3000, function()

local options =
{
appPermission = "android.permission.POST_NOTIFICATIONS",
urgency = "Critical",
listener = appPermissionsListener,
rationaleTitle = "Notification access required",
rationaleDescription = "Notification access is required to send notifications",
settingsRedirectTitle = "Alert",
settingsRedirectDescription = "Without the ability to take notification, this app cannot properly function. Please grant notification access within Settings."
}
native.showPopup( "requestAppPermission", options )
end )
`

Screenshot_20230726-145639

@Shchvova
Copy link
Contributor

Shchvova commented Aug 6, 2023

So... I did quite a bit of testing and I have good and bad news - good news that it kinda works. Bad news - back button stuff is broken. To test it you need to set <application android:enableOnBackInvokedCallback="true" /> as enable "Predictive back animations" in Developer settings on device. If you do that one can see that back functionality breaks in webPopUp, and generally whent trying to intercept system back button event. I think more thoughfull code should be added to do that. Luckuly we can opt out from it by setting that setting to 'false'

About Notifications, I think we should implement the popup if user tries to schedule a notification without a prior request, or tries to register for notifications. I will take care of it.

Great job, @scottrules44. Thanks a lot for taking a look into it.

@Shchvova Shchvova merged commit f12fb57 into coronalabs:master Aug 18, 2023
1 check passed
@scottrules44 scottrules44 deleted the Android33 branch August 21, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants