Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paused timer doesn't get removed #9

Open
lifestremer opened this issue Nov 14, 2022 · 0 comments
Open

Paused timer doesn't get removed #9

lifestremer opened this issue Nov 14, 2022 · 0 comments

Comments

@lifestremer
Copy link

Hi,
I just came across a memory leak and found out that the issue is in timer lib because it doesn't remove pause timer from array so it stays in memory forever.

In function timer.cancel 3 arrays get checked - _runlist, _pausedTimers and toInsert.

But in timer._remove only _runlist and toInsert are checked which means that if timer is paused, it gets canceled but it's never removed because this function doesn't check if timer is in _pausedTimers to remove it.

Can you please take a look and add fix this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant