Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Offset from paginated API's #1045

Closed
bodhish opened this issue May 12, 2021 · 9 comments
Closed

Remove Offset from paginated API's #1045

bodhish opened this issue May 12, 2021 · 9 comments
Labels
bug Something isn't working cef good first issue Good for newcomers help wanted Extra attention is needed stale waiting for update PR is been dead for a long time

Comments

@bodhish
Copy link
Member

bodhish commented May 12, 2021

Remove the usage of Offset from paginated API's

@vigneshhari vigneshhari added bug Something isn't working help wanted Extra attention is needed important labels May 12, 2021
@divyagar divyagar self-assigned this May 12, 2021
@divyagar
Copy link
Contributor

@bodhish @vigneshhari Instead of offset can we use page numbers here to fetch data?
For example https://careapi.coronasafe.in/api/v1/patient/?page=1 will fetch first 15 records.

@vigneshhari
Copy link
Member

vigneshhari commented May 12, 2021

The issue also states the same right ? Use only page numbers, remove the use of offsets everywhere.

@bodhish
Copy link
Member Author

bodhish commented May 13, 2021

The usages of offset should be removed from frontend

@bodhish bodhish added this to Triage in Care Development (old) via automation May 13, 2021
@bodhish bodhish moved this from Triage to Awaiting UI Development in Care Development (old) May 13, 2021
@bodhish bodhish added the cef label May 13, 2021
@vigneshhari vigneshhari added Frontend and removed cef labels May 13, 2021
@bodhish bodhish added the cef label May 27, 2021
@sam9111 sam9111 self-assigned this May 28, 2021
@sam9111
Copy link
Contributor

sam9111 commented May 28, 2021

Should offset be replaced by page or just removed? @bodhish

@bodhish
Copy link
Member Author

bodhish commented Jun 14, 2021

Removed @sam9111

@arihant-2310
Copy link
Contributor

Is this issue still open? If so, I can pick it up.

@stale
Copy link

stale bot commented Oct 1, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the waiting for update PR is been dead for a long time label Oct 1, 2022
@stale
Copy link

stale bot commented Oct 9, 2022

Hi, @${author}, This pr/issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs for 7 more days. Thank you for your contributions.

@stale stale bot added the stale label Oct 9, 2022
@khavinshankar
Copy link
Member

closing this as resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cef good first issue Good for newcomers help wanted Extra attention is needed stale waiting for update PR is been dead for a long time
Projects
Status: Done
Care Development (old)
  
Awaiting UI Development
8 participants