Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent SearchInput component from triggering esc key action if query is empty #4207

Closed
rithviknishad opened this issue Dec 4, 2022 · 0 comments · Fixed by #4239
Closed
Assignees

Comments

@rithviknishad
Copy link
Member

Describe the bug
Currently when there's no search query, and if we press empty, it refreshes the page by explicitly setting the query to empty in query params.

To Reproduce
Steps to reproduce the behavior:

  1. Go to facilities page
  2. Press Esc

Expected behavior
No change to be made in the query params if search is already empty. (Avoid triggering the action in the first place)

Screenshots

2022-12-04.11-22-08.mp4

Desktop (please complete the following information):

  • OS: ubuntu 22.10
  • Browser: firefox
    Additional context
    Add any other context about the problem here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants