Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage react-csv package #5481

Closed
rithviknishad opened this issue May 18, 2023 · 0 comments · Fixed by #5502
Closed

Remove usage react-csv package #5481

rithviknishad opened this issue May 18, 2023 · 0 comments · Fixed by #5502
Assignees
Labels

Comments

@rithviknishad
Copy link
Member

Follow up of #5476

Currently, we are using the react-csv package only to serve the already formatted CSV file contents from the backend as a downloadable link.

However, as of react-csv/react-csv@7d00a46 they have introduced escaping commas with double quotes without checking if it's already escaped. This makes contents that are already escaped such as "Hello, World" be formatted as ""Hello, World"" which causes issues in the columns.

Example file with this issue: export_2023-05-18T06_42_30.339Z.csv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants