Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DialogModal instead of SlideOverCustom for Weekly working hours of user #6009

Closed
Pranshu1902 opened this issue Aug 5, 2023 · 3 comments

Comments

@Pranshu1902
Copy link
Contributor

Describe the bug
We are using SlideOverCustom to edit the Weekly Working Hours for users which seems unnecessary and takes a lot of space. Instead, we can use DialogModal to do the same, it would be much more cleaner.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://care.coronasafe.in/users
  2. Click on Set Weekly Working Hours for any user
  3. See error

Screenshots
image

DialogModal would look like this:
image

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@Pranshu1902
Copy link
Contributor Author

What's your opinion @khavinshankar @nihal467 @gigincg

@Ashesh3
Copy link
Member

Ashesh3 commented Aug 7, 2023

The decision to implement the SlideOver component was made in order to maintain consistency with the user interface of the other buttons on the User Info card. The Skills and Linked Facilities buttons both utilize the SlideOver component, and it was considered to provide a similar user experience for all buttons. While this may be a low priority issue, it is open for discussion!

@Ashesh3
Copy link
Member

Ashesh3 commented Aug 8, 2023

Closing after an internal discussion. Refer to the above comment for more details.

@Ashesh3 Ashesh3 closed this as completed Aug 8, 2023
@Ashesh3 Ashesh3 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants