Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset import feature minor enhancement #6399

Closed
nihal467 opened this issue Oct 5, 2023 · 1 comment · Fixed by #6400
Closed

Asset import feature minor enhancement #6399

nihal467 opened this issue Oct 5, 2023 · 1 comment · Fixed by #6400
Assignees
Labels
P1 breaking issue or vital feature

Comments

@nihal467
Copy link
Member

nihal467 commented Oct 5, 2023

Describe the bug

  • even though the location is marked mandatory, there is no validation occurring in the asset import
  • once we click import post selection, the users are not given any indication that the data is processing

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://care.coronasafe.in/assets
  2. Select facility and import asset list
  3. without selecting the location click import
  4. See error

Expected behavior

  • add a location field validation in the asset import
  • upon clicking import button, it should be giving import processing notification and a loader in the import button to show, the import is processing

Screenshots

image

@nihal467 nihal467 added the P1 breaking issue or vital feature label Oct 5, 2023
@github-actions
Copy link

github-actions bot commented Oct 5, 2023

⚠️ Refrain from assigning this issue to yourself if you have another P1 issue assigned that is not yet closed.
@Ashesh3 kindly acknowledge this message by commenting 'Acknowledged' below.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 breaking issue or vital feature
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants