Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show more monitors in CNS on very large displays #6503

Open
rithviknishad opened this issue Oct 26, 2023 · 9 comments
Open

Show more monitors in CNS on very large displays #6503

rithviknishad opened this issue Oct 26, 2023 · 9 comments
Labels

Comments

@rithviknishad
Copy link
Member

Describe the bug
When CNS is opened in large 4K displays, 75% of the screen space is wasted.

To Reproduce
Steps to reproduce the behavior:

  1. Visit https://deploy-preview-6396--care-net.netlify.app/facility/0c95c7f0-e1d2-4aff-83fa-933cef60d3a8/cns on a 4K display

Expected behavior
On large displays, render more vitals monitors into view per page.

Screenshots

image

@kshitijv256
Copy link
Contributor

9 monitors if available should be fine in this size screen i guess
or maybe increase the size of monitors to use most of screen with same no. as it is

I would like to work on it.

Copy link

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, @aparnacoronasafe, This issue has been automatically marked as stale because it has not had any recent activity.

@github-actions github-actions bot added the stale label Nov 12, 2023
@ayush-seth
Copy link
Contributor

I can pick this up if still required

@MjStar24
Copy link

hey @nihal467 I would like to work on this can you assign this to me

@MjStar24
Copy link

hey @rithviknishad when I am clicking on the above it is showing no data found

Screenshot 2024-03-18 173337

@rithviknishad
Copy link
Member Author

Try logging in as devdistrictadmin Coronasafe@123 instead.

@MjStar24
Copy link

thanks @rithviknishad its working!

@MjStar24
Copy link

hey @rithviknishad I have raised the pull request for this issue

what I have done :

-by default 6 monitors will displayed per view page for small screens
-for large screens 9 monitors will be displayed per view page for 4k displays
-for this I have used window.resize and react hooks to check the display size and change number of monitors according to display size

@nihal467
Copy link
Member

@MjStar24 Unassigning you from this issue due to inactivity. Feel free to reassign yourself if you are still working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Up Next
Development

Successfully merging a pull request may close this issue.

5 participants