Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure Facility: Unnecessary multiple cancel buttons present #6552

Closed
rithviknishad opened this issue Nov 6, 2023 · 6 comments · Fixed by #6579
Closed

Configure Facility: Unnecessary multiple cancel buttons present #6552

rithviknishad opened this issue Nov 6, 2023 · 6 comments · Fixed by #6579
Assignees
@KshitijTodkar48
Labels
good first issue Good for newcomers

Comments

@rithviknishad
Copy link
Member

Describe the bug
On the configure facility page, there are two cards and each has its own cancel button although both do the same behaviour-wise.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the configure facility page.

Expected behavior
Remove the cancel button in favour of the back button, or have only one cancel button.

Screenshots
image
@rithviknishad rithviknishad added the good first issue Good for newcomers label Nov 6, 2023
@KshitijTodkar48
Copy link
Contributor

KshitijTodkar48 commented Nov 9, 2023 •
edited
Loading

I want to do it. Please assign this to me.

@KshitijTodkar48
Copy link
Contributor

And please check if this is ok?
Screenshot 2023-11-09 163609

@rithviknishad
Copy link
Member Author

The back button would suffice I guess. Let's remove both. cc: @nihal467

@KshitijTodkar48
Copy link
Contributor

Is this good @rithviknishad ?
Screenshot 2023-11-09 193031

@KshitijTodkar48 KshitijTodkar48 mentioned this issue Nov 9, 2023
Merged
3 tasks
@rithviknishad
Copy link
Member Author

I mean, there is a back button at the top left already right? That'd be enough.

@KshitijTodkar48
Copy link
Contributor

Sorry, I don't know how I missed that. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KshitijTodkar48 KshitijTodkar48

Labels
good first issue Good for newcomers
Projects
Care
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed unnecessary multiple cancel buttons and added a Back button. KshitijTodkar48/care_fe
2 participants
@rithviknishad @KshitijTodkar48