Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds watermark to Camera Feed and disables access to context menu. #7885

Merged
merged 3 commits into from
May 28, 2024
Merged

Adds watermark to Camera Feed and disables access to context menu. #7885

merged 3 commits into from
May 28, 2024

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented May 23, 2024 •
edited

Proposed Changes

  • Fixes Watermarks for camera feed #7872
  • Added logic to ensure watermark cannot be removed from the DOM.
  • Disable context menu access for Camera Feed's video element.
image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team as a code owner May 23, 2024 07:03
@vercel Vercel
Copy link

vercel bot commented May 23, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 4:41am

@netlify Netlify
Copy link

netlify bot commented May 23, 2024 •
edited

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 0644de8
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66556067f436ba000863679a
😎 Deploy Preview https://deploy-preview-7885--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress Cypress
Copy link

cypress bot commented May 23, 2024 •
edited

Passing run #2641 ↗︎

0 124 0 0 Flakiness 0

Details:

Adds watermark to Camera Feed and disables access to context menu.
Project: CARE Commit: 0644de80a0
Status: Passed Duration: 03:01 💡
Started: May 28, 2024 4:46 AM Ended: May 28, 2024 4:49 AM

Review all test suite changes for PR #7885 ↗︎

@github-actions GitHub Actions
Copy link

👋 Hi, @rithviknishad,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label May 27, 2024
@rithviknishad rithviknishad removed the merge conflict pull requests with merge conflict label May 28, 2024
@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 3e12e19 into develop May 28, 2024
62 checks passed
@khavinshankar khavinshankar deleted the rithviknishad/feat/camera-feed-watermark branch May 28, 2024 05:54
@github-actions GitHub Actions
Copy link

@rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

Assignees
No one assigned
Labels
needs review tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Watermarks for camera feed
3 participants
@rithviknishad @nihal467 @khavinshankar