Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements to size of filters in Leaderboard page #317

Open
2 tasks
rithviknishad opened this issue Mar 4, 2024 · 8 comments
Open
2 tasks

Enhancements to size of filters in Leaderboard page #317

rithviknishad opened this issue Mar 4, 2024 · 8 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@rithviknishad
Copy link
Member

Currently, the size of each filter is not proper.

  • Search filter should occupy 1/3rd of the total width
  • And the rest of the items should be equally spaced (The role filter is taking unequal space)
image
@HARSHDOIPHODE
Copy link
Contributor

can you please assign me

@HARSHDOIPHODE
Copy link
Contributor

@rithviknishad please review the PR

@rudra321
Copy link
Contributor

Hey @rithviknishad , can I work on this issue ?

@rudra321
Copy link
Contributor

I have done this. Is this okay can you please check and tell ?

image

@rithviknishad
Copy link
Member Author

Looking great!

@rudra321
Copy link
Contributor

Okay thank you, I'll move ahead with it.

I also found something which might be an issue. Its my first time contributing so I'm not sure about this.

Previous Mobile view :

image

New Mobile View :

image

This new view is fine ? Or I revert it to previous version ? Or should I report it as a bug in issue section ?

@rithviknishad
Copy link
Member Author

rithviknishad commented Apr 29, 2024

This issue is not present in the current deployment, right? Couldn't replicate it from my end. I believe this issue was caused by the code changes made to solve this issue.

Anyhow, the new view looks fine! You can push it in the same PR.

@rudra321
Copy link
Contributor

rudra321 commented May 2, 2024

Hi, can you please review my PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants