-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimizing /people route #421
Comments
I am busy for 2 weeks and will only be available to solve this issue after these 2 weeks. So anyone who is willing to solve this issue in these 2 weeks are welcome. |
@rash-27 i think you forgot to put the condition when to dynamically import |
@rithviknishad sorry for making a PR before getting assigned. Just happened to get some free time today. |
@Re-Dei what I thought is that currently we are rendering '/people' on the server side and showing cards using tailwind (using opacity so that we are fetching them while rendering on the server) ,and converting that to a client side component may take away the advantages of the SSR right ? |
@rash-27 only the hover card is being rendered client side in my PR. You can see to learn more. |
Sure , I'll look into it . |
The /people route has become slow because of the new hover feature. Since hover feature is only required when hovered, implement a dynamic import strategy to solve this issue.
Docs: https://nextjs.org/docs/pages/building-your-application/optimizing/lazy-loading
The text was updated successfully, but these errors were encountered: