Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: move boilerplate code from each page to _app.js #56

Closed
2 tasks done
khavinshankar opened this issue Jun 9, 2022 · 2 comments · Fixed by #60
Closed
2 tasks done

Refactor: move boilerplate code from each page to _app.js #56

khavinshankar opened this issue Jun 9, 2022 · 2 comments · Fixed by #60
Assignees
@khavinshankar

Comments

@khavinshankar
Copy link
Member

khavinshankar commented Jun 9, 2022 •
edited
Loading

Todo:

  • create a component for Footer
  • remove Header, PageHead and Footer from each page and move it into _app.js
@khavinshankar khavinshankar self-assigned this Jun 9, 2022
@rithviknishad
Copy link
Member

@khavinshankar footer component has been refactored in https://github.com/coronasafe/leaderboard/pull/52/files#diff-3ebccc91178536d06703a58be49b5077d0535c8ff3ab2512af21ca060c5b4e77

@khavinshankar
Copy link
Member Author

@rithviknishad got it 👍 thanks for the headsup, I'll just push additional changes after that pr is merged

@khavinshankar khavinshankar mentioned this issue Jun 17, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@khavinshankar khavinshankar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added Search, Sort and Toggle Core Members Functionality coronasafe/leaderboard
2 participants
@rithviknishad @khavinshankar