Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing Clover: Error communicating with github! #27

Closed
bill-fischer opened this issue Oct 18, 2019 · 10 comments
Closed

Installing Clover: Error communicating with github! #27

bill-fischer opened this issue Oct 18, 2019 · 10 comments

Comments

@bill-fischer
Copy link

Hello. I am a new user of gibMacOS, so apologies if this is a known issue. I have followed the steps and am trying to build a USB using recovery media for Catalina. Everything seems to be working fine with MakeInstall.bat, but when it gets to "Installing Clover" it stops and presents the error message: "Error communicating with github!"

Any ideas? I have tried using a different PC and with both Admin and non-admin execution of the bat file. Any assistance appreciated! Thanks.
Annotation 2019-10-18 144516

@20Koen02
Copy link

I have this exact same issue. I have done this process several times now. Maybe something changed with the github url it's downloading from?

@corpnewt
Copy link
Owner

I won't be able to look into this for a bit - but I'll update when I get a chance to.

-CorpNewt

@bill-fischer
Copy link
Author

Thank you @corpnewt ! Appreciate the feedback.

@20Koen02
Copy link

@corpnewt @bill-fischer I worked out the issue. The latest release of cloverbootloader doesn't contain any assets (the compiled code)
@bill-fischer for now, you can manually edit the code to use the previous version of clover which does contain the assets. Edit MakeInstall.py and replace the url of the self.clover_url variable in the __init__() function with https://api.github.com/repos/CloverHackyColor/CloverBootloader/releases/20627694 (Release v2.5k-5096 of clover)

@corpnewt you know what to do. Check for assets and if none check the previous versions

@bill-fischer
Copy link
Author

Wow, thanks, @20Koen02 . Never would have been able to do that myself. Thanks again!

@corpnewt
Copy link
Owner

Seems the latest one works now - but I also bulletproofed the code a bit in this commit. Thanks for letting me know and being patient.

-CorpNewt

@bill-fischer
Copy link
Author

@corpnewt thanks again, and thanks for creating such great software!

@bill-fischer
Copy link
Author

Hi. seems to be happening again.

@corpnewt
Copy link
Owner

I just ran a quick test with the code MakeInstall.py uses (as I'm on macOS right now with py 3.7.5), and it located the download link just fine:

>>> import downloader as dl
>>> d = dl.Downloader()
>>> import json
>>> clover_url = "https://api.github.com/repos/CloverHackyColor/CloverBootloader/releases"
>>> json_data = d.get_string(clover_url,False)
>>> j_list = json.loads(json_data)
>>> for j in j_list:
...     dl_link = next((x.get("browser_download_url", None) for x in j.get("assets", []) if x.get("browser_download_url", "").lower().endswith(".lzma")), None)
...     if dl_link:
...         break
... 
>>> dl_link
'https://github.com/CloverHackyColor/CloverBootloader/releases/download/5097/CloverISO-5097.tar.lzma'

May be a network issue on your side - or an outdated version of py that's being rejected by github?

-CorpNewt

@bill-fischer
Copy link
Author

OK. Yeah. Makes sense. The error message is different this time. Just says it's unable to download. Regardless, thanks for checking it so quickly. Again, the software is great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants