Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User-friendly message when callable schema fails in both Update and Create views #183

Open
corradio opened this issue May 27, 2024 · 0 comments

Comments

@corradio
Copy link
Owner

corradio commented May 27, 2024

An exception in a the callable schema of an integration won't be caught and will cause a 500 when user creates/duplicates/edits a metric. This can happen for numerous reasons (for example an HTTP call which is not authorized anymore).

For now, only invalid_grant errors are handled, and they are only handled in the UpdateView (not CreateView).

We should:

  • have a unified way of handling exceptions between create and update views
  • show a friendly user message both when the metric can be re-authorised (e.g. invalidgrant) and when the error is generic
  • mention the issue is with the integration and link to github
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant