Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JAVA_HOME/PATH and empty folder remains after uninstall Corretto x86 and x64 #38

Closed
yamadamn opened this issue Jan 12, 2019 · 6 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@yamadamn
Copy link

Describe the bug

I uninstalled both Corretto x86/x64 in Windows;
But the JAVA_HOME and PATH environment variable remains, and the installed directory remains empty.

To Reproduce

  1. Install both Corretto x86/x64 in Windows (with default option)
  2. Uninstall both Corretto x86/x64.

Expected behavior

Both JAVA_HOME and PATH (x86/x64) environment will be removed after uninstall.

Screenshots

after-uninstall-java_home path folder

It depends on install/uninstall order.

Platform information

OS: Windows 10
Version "build 1.8.0_192-amazon-corretto-preview2-b12"

Additional context

This issue is related to #15, #22 and #37 .

@davecurrie
Copy link
Contributor

Hi @yamadamn. Thanks for letting us know, we're taking a deeper look and will get back with an answer soon.

@davecurrie davecurrie added the bug Something isn't working label Jan 17, 2019
@yoroto
Copy link

yoroto commented Jan 26, 2019

Hi @yamadamn ,

Thank you for submitted the issue!

This is actually an known issue of Windows 10. You can find the Microsoft KB here: https://support.microsoft.com/en-us/help/3166232/windows-installer-package-doesn-t-update-system-environment-variables If you log off and log in again, you should see the environment variables get updated and the folder get removed. Otherwise you can apply the Microsoft hotfix mentioned in the post. Let me know whether it works for you.

We will also look into adding an option to warn Windows 10 customer to sign off after uninstall if the hotfix is not present. So I will leave this issue open until we added the improvement.

@yamadamn
Copy link
Author

Hi @yoroto ,

Thank you for your investigation.
I have tried again with Corretto 8.202.08.2.
But, unfortunately, the behavior has not improved when logoff and login again, and even after the restart.
JAVA_HOME/PATH environment variables and empty folder still remains.
Could you reproduce the issue at your end?
I think this behavior is your installer's limitation. If so, I will give up this issue to be resolved.

@yoroto
Copy link

yoroto commented Feb 7, 2019

Hi @yamadamn

I have managed to reproduce your issue. The root cause was because the x86 and x64 MSIs share some installer code, and therefore are having the same IDs for some installation components. When you uninstall both of them, it confused the msiexec on which one to remove.

We will try to fix this in future releases. Thank you for submitting the issue!

@EricEdens
Copy link
Contributor

@yoroto : When you look at this, it also happens when updating an existing MSI. Here are the steps that I did:

  1. Install 64-bit 8u202 MSI
  2. Install 64-bit 8u212 MSI
  3. Uninstall 64-bit 8u202

Below is a screenshot of the environment variable editor in Windows 10:

image

@davecurrie davecurrie added this to the 8u222 milestone Jun 13, 2019
@cliveverghese
Copy link
Contributor

This issue was resolved in 8.222.x.x. Closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants