Construct new YAML serializer object on every load/save operation #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure if this is a good idea worth keeping. It may or may not fix a bug I've seen months ago. In return, it introduces complexity and brittleness into my code, and could stop working in a future ruamel.yaml update. Also `pip install` doesn't pin the exact ruamel.yaml version (accepting higher versions that could break my code), only `poetry install` pins an exact version.
|
someday? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is a good idea worth keeping. It may or may not fix a bug I've seen months ago. In return, it introduces complexity and brittleness into my code, and could stop working in a future ruamel.yaml update.
If future versions of ruamel.yaml break my code,
pip install corrscopecan install higher versions of ruamel.yaml, resulting in a broken corrscope install (as long as they have the same major version). Onlypoetry install(and in turn, Appveyor's Windows binaries) pin an exact version.Fixes #288. Fixes #368.