Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --maxrestart argument to change max deamon restart delay #91

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wader
Copy link

@wader wader commented Aug 8, 2020

Fixes #90

@wader
Copy link
Author

wader commented Aug 8, 2020

Maybe there is some better way of passing around maxRestartDelay?

@wader
Copy link
Author

wader commented Aug 17, 2020

--maxrestart might be confusing name, could --maxrestartdelay be better but a bit long?

Maybe it would make sense if the option is per daemon instead but not sure about syntax, something like daemon 3s: ...? or extend the syntax to key=value so something like daemon maxrestartdelay=3: ...? should be a global option also, @maxrestartdelay=3?

@atombender
Copy link

--maxdelay or --maxbackoffdelay?

I'd love to get this merged.

@wader
Copy link
Author

wader commented Sep 15, 2020

@cortesi let me if you think it should be done in different way

@pavel-kolesnikov
Copy link

Hi @wader . I'm working on #101 (fixes #86 & #55, hopefully).
May be the maxrestart could be implemented like the mentioned silence directive, per block also.
WDYT?

@wader
Copy link
Author

wader commented May 5, 2021

@pavel-kolesnikov hello! yes could be an option, then it would configure it for all daemons in that block? i've thought about having the option per daemon which is nice as it make it very clear what it is used for.

@pavel-kolesnikov
Copy link

pavel-kolesnikov commented May 5, 2021

@pavel-kolesnikov hello! yes could be an option, then it would configure it for all daemons in that block? i've thought about having the option per daemon which is nice as it make it very clear what it is used for.

Basically, per Block. Like this:

** {
  silence: 1s
  prep: echo "no more then once a second"
}

Hmmmm... Option per daemon is nice also. But then extensive lexer rework needed, I think. At least 2 options:

  • extend daemons to blocks themselves (and we inventing YAML\JSON here)
  • develop something like +k:v (and again, inventing wheel :( )

@wader
Copy link
Author

wader commented May 9, 2021

Nice summary. Opt 2 would also follow how +sigterm etc works now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: customize backoff parameters
3 participants