Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cortex.css file existence checked before running pre-build script #519

Open
rhgb opened this issue Jan 26, 2016 · 2 comments
Open

cortex.css file existence checked before running pre-build script #519

rhgb opened this issue Jan 26, 2016 · 2 comments

Comments

@rhgb
Copy link
Contributor

rhgb commented Jan 26, 2016

The problem issued in #478 closed by 0e3b9fc reappeared after committing 89ec5ad:

       'read_cortex_json',
 +      'clean_cortex_json',    // this line is originally located after 'run_prebuild_script'
 +      'prepare_build_type',
        'run_preinstall_script',
        'run_prebuild_script',

so what's the intention of 89ec5ad and how should we fix it again?

@chinesedfan
Copy link
Contributor

clean_cortex_json will set pkg.css to be an empty array if no files were found. See cortexjs/read-cortex-json#8.

I think the right order is run_prebuild_script -> clean_cortex_json -> prepare_build_type.

@chinesedfan
Copy link
Contributor

But run_prebuild_script needs prepare_build_type. Because if build_type != 'full', we can skip run_prebuild_script. Then these 3 steps become a loop. :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants