Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid processing http requests that have been cancelled by the client #1453

Closed
deliahu opened this issue Oct 15, 2020 · 0 comments · Fixed by #2135
Closed

Avoid processing http requests that have been cancelled by the client #1453

deliahu opened this issue Oct 15, 2020 · 0 comments · Fixed by #2135
Assignees
@vishalbollu
Labels
enhancement New feature or request timecapped Assigned a limited amount of time
Milestone
v0.35

Comments

@deliahu
Copy link
Member

deliahu commented Oct 15, 2020 •
edited

Description

If the client cancels a prediction request (e.g. due to timeout), the request should not be processed.

If it's difficult to cancel a request that is actively being processed, that could be converted into a separate github issue, and the initial implementation could be to only cancel requests that have not yet started processing.

May be related to #1452
@deliahu deliahu added the enhancement New feature or request label Oct 15, 2020
@deliahu deliahu added this to To prioritize in Cortex via automation Oct 15, 2020
@deliahu deliahu mentioned this issue Nov 17, 2020
Open
@deliahu deliahu removed this from To prioritize in Cortex Nov 26, 2020
@vishalbollu vishalbollu added the research Determine technical constraints label Mar 31, 2021
@vishalbollu vishalbollu changed the title Avoid processing requests that have been cancelled by the client Avoid processing http requests that have been cancelled by the client Mar 31, 2021
@vishalbollu vishalbollu changed the title Avoid processing http requests that have been cancelled by the client [Timecapped] Avoid processing http requests that have been cancelled by the client Mar 31, 2021
@RobertLucian RobertLucian added this to the v0.33 milestone Apr 2, 2021
@deliahu deliahu removed this from the v0.33 milestone Apr 13, 2021
@vishalbollu vishalbollu self-assigned this Apr 14, 2021
@vishalbollu vishalbollu added the timecapped Assigned a limited amount of time label Apr 14, 2021
@vishalbollu vishalbollu changed the title [Timecapped] Avoid processing http requests that have been cancelled by the client Avoid processing http requests that have been cancelled by the client Apr 14, 2021
@vishalbollu vishalbollu removed the research Determine technical constraints label Apr 28, 2021
@vishalbollu vishalbollu mentioned this issue Apr 30, 2021
Merged
2 tasks
@deliahu deliahu added this to the v0.35 milestone May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vishalbollu vishalbollu

Labels
enhancement New feature or request timecapped Assigned a limited amount of time
Projects
None yet
Milestone
v0.35
Development

Successfully merging a pull request may close this issue.

Check if a request has been abandoned before working on it cortexlabs/cortex
3 participants
@deliahu @vishalbollu @RobertLucian