Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support max_concurrency for async APIs #2200

Closed
deliahu opened this issue May 28, 2021 · 0 comments · Fixed by #2376
Closed

Support max_concurrency for async APIs #2200

deliahu opened this issue May 28, 2021 · 0 comments · Fixed by #2376
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@deliahu
Copy link
Member

deliahu commented May 28, 2021

Description

Currently, async APIs process one request at a time (i.e. max_concurrency is 1). Support the user specifying max_concurrency > 1, which will result in concurrent requests into the container.

Notes

One approach is to have multiple goroutines, all pulling from the SQS queue. Another option is to have a single goroutine pulling more than one message at a time from the queue, and then distributing the messages across goroutines (care will have to be taken to avoid idle goroutines).

Misc

  • Update async/autoscaling.md and async/configuration.md accordingly (add new sections, update default values for target_in_flight and max_concurrency, etc)

  • Here is the commit which removed max_concurrency from the async docs: 7508c76

@deliahu deliahu added the enhancement New feature or request label May 28, 2021
@miguelvr miguelvr assigned miguelvr and unassigned RobertLucian Jul 21, 2021
@deliahu deliahu added this to the v0.40 milestone Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants