Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify metrics for object stores #2478

Closed
tomwilkie opened this issue Apr 17, 2020 · 2 comments
Closed

Unify metrics for object stores #2478

tomwilkie opened this issue Apr 17, 2020 · 2 comments
Labels
stale storage/chunks Chunks storage engine type/observability To help know what is going on inside Cortex

Comments

@tomwilkie
Copy link
Contributor

We're missing any metrics for the azure client[1], and we have different metrics for S3[2] and GCS[3]. We should rationalise this into some sort of middleware for the object store interface that makes this more consistent.

[1] https://github.com/cortexproject/cortex/blob/master/pkg/chunk/azure/blob_storage_client.go
[2] https://github.com/cortexproject/cortex/blob/master/pkg/chunk/aws/s3_storage_client.go#L26
[3]

func gcsInstrumentation(ctx context.Context, scope string) (option.ClientOption, error) {

@tomwilkie tomwilkie added good first issue These are great first issues. If you are looking for a place to start, start here! hacktoberfest help wanted type/observability To help know what is going on inside Cortex labels Apr 17, 2020
@bboreham
Copy link
Contributor

bboreham commented Feb 4, 2021

Less likely we will do this now that Blocks are preferred to Chunks.

@bboreham bboreham added storage/chunks Chunks storage engine and removed good first issue These are great first issues. If you are looking for a place to start, start here! hacktoberfest help wanted labels Jun 25, 2021
@stale
Copy link

stale bot commented Sep 23, 2021

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 23, 2021
@stale stale bot closed this as completed Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale storage/chunks Chunks storage engine type/observability To help know what is going on inside Cortex
Projects
None yet
Development

No branches or pull requests

2 participants