Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to mark module as "visible" for users #2596

Closed
pstibrany opened this issue May 15, 2020 · 2 comments
Closed

Make it possible to mark module as "visible" for users #2596

pstibrany opened this issue May 15, 2020 · 2 comments
Labels

Comments

@pstibrany
Copy link
Contributor

Not all modules should be selectable as "targets", only user-visible ones. For example, selecting "api" or "memberlist-kv" as targets makes no sense (and actually selecting "memberlist-kv" leads to panic, since this module doesn't depend on anything, but Cortex.Run method still tries to register some routes to API -- which is not initialized).

Once we have ability to set some modules as user-visible, InitModuleServices should report available modules if incorrect module name is passed to it.

/cc @annanay25

@stale
Copy link

stale bot commented Jul 14, 2020

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 14, 2020
@pstibrany
Copy link
Contributor Author

Implemented in #2752.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant