Table-Manager: Create/Update table before deleting tables

[jtlisi]

cortex/pkg/chunk/table_manager.go

Lines 340 to 350 in e2a36a7

	if err := m.deleteTables(ctx, toDelete); err != nil {
	return err
	}
	if err := m.createTables(ctx, toCreate); err != nil {
	return err
	}
	if err := m.updateTables(ctx, toCheckThroughput); err != nil {
	return err
	}

When the table manager actually attempts to sync and operate on the chunk storage backend it will proceed in the following order:

1. Delete
2. Create
3. Update

If any of these operations fail at any point, the entire sync will return. This can lead to issues for users who have delete operations that are unsuccessful, since new tables will not be created. This means new data will not be flushed since no table exists to support it. I propose the following order:

1. Create
2. Update
3. Delete

This order will prioritize write availability over storage retention.

[stale]

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

[pracucci]

Still valid

[stale]

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

[pracucci]

Still valid, help wanted!

[daemon1024]

Hello, I was looking to getting involved with the project. Can I work on this?

[pracucci]

Hi @daemon1024 none is working on this issue. If you're a Cortex user, I would suggest you to start from an issue you will directly benefit from.

For example, the table-manager is used only by the chunks storage, and a good amount of Cortex users (including my employer) are moving or already moved to the blocks storage, so if you're not running the chunks storage I would suggest you to take a look at the blocks storage issues, which is the direction where the community is heading to.

[daemon1024]

Hi @pracucci , I am not a Cortex user, I am a student looking to get involved with CNCF in general this seemed like an interesting project hence looking into the good-first-issues. Thank You.

[jtlisi]

Closing this since chunks storage is now in maintenance mode.