You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The defer in that function should then log "TransferChunks failed" and go back to PENDING state, but I don't see that log, which is explained by this line checking the in-memory state:
What do you think should happen? How do you suggest to modify check in Ingester.transfer()?
Changing state doesn't seem appropriate. As of now the only possible transition from ACTIVE state is to LEAVING state. I don't think that's correct answer.
Other possibilities seem even worse (going back to PENDING/JOINING), because transfer has already finished.
The change in memory state is made before updating Consul, and no attempt is made to revert the former if the latter fails:
cortex/pkg/ring/lifecycler.go
Lines 710 to 711 in a87c25f
I noticed this because I got this log message:
That's coming from here:
cortex/pkg/ingester/transfer.go
Line 204 in f27cef8
The
defer
in that function should then log "TransferChunks failed" and go back to PENDING state, but I don't see that log, which is explained by this line checking the in-memory state:cortex/pkg/ingester/transfer.go
Line 185 in f27cef8
(Also odd: metrics show it did go to ACTIVE state)
The text was updated successfully, but these errors were encountered: