Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry on prometheus list rules #5668

Open
emanlodovice opened this issue Nov 21, 2023 · 2 comments
Open

Add retry on prometheus list rules #5668

emanlodovice opened this issue Nov 21, 2023 · 2 comments

Comments

@emanlodovice
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Currently the PrometheusRules api endpoint, at the worst case, will list all the rules from all rules. For a cluster with hundreds of rulers one api call will trigger hundreds of GRPC calls, one for each ruler, and if one of these GRPC calls fail we return 5xx. So as the number of rulers increase, the chance of one grpc call failing causing the entire list rules call to fail also increases.

Describe the solution you'd like
There should be a retry mechanism on the grpc call to make the endpoint more robust. https://github.com/cortexproject/cortex/blob/master/pkg/ruler/ruler.go#L907

@emanlodovice
Copy link
Contributor Author

@emanlodovice
Copy link
Contributor Author

Hmm i guess backoff_on_ratelimits and backoff_config on the ruler_client config can be used to tune the retry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant