Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cortex queryable is incompatible with latest Prometheus #787

Closed
bboreham opened this issue Apr 6, 2018 · 2 comments
Closed

Cortex queryable is incompatible with latest Prometheus #787

bboreham opened this issue Apr 6, 2018 · 2 comments

Comments

@bboreham
Copy link
Contributor

bboreham commented Apr 6, 2018

I had to revert #763 because the querier started returning blank for all queries.

querier/main.go creates two structs with a flag saying one is for metadata-only and one is for queries.

@juliusv says:

the web API took an engine (which was only used for full queries) and a querier (which was only used for metadata queries)
now the engine only takes a queryable and also creates queries based on it, while the engine doesn't know of a queryable upon construction

So we need to either change upstream Prometheus to tell us what kind of result is needed, or figure out some other way to differentiate within Cortex.

@bboreham
Copy link
Contributor Author

bboreham commented Apr 6, 2018

I believe we can differentiate based on whether the SelectParams passed to Select is nil. But this is somewhat fragile, relying on the particular implementation of Prometheus. Then again, that was what we were doing before.

@bboreham
Copy link
Contributor Author

bboreham commented Jun 4, 2018

Fixed in #802

@bboreham bboreham closed this as completed Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant