Skip to content
This repository has been archived by the owner on Nov 22, 2022. It is now read-only.

File upload issue #79

Closed
zmija opened this issue May 23, 2019 · 3 comments
Closed

File upload issue #79

zmija opened this issue May 23, 2019 · 3 comments
Assignees
Labels
Type: Bug Something isn't working

Comments

@zmija
Copy link
Contributor

zmija commented May 23, 2019

As a user, I create a new record with file upload options. I click on the uploader and select the file.

Current result:

  • the loader (progress bar) doesn't start
  • preview of the file is invisible
  • when I hit 'Save' for the first time, nothing happens
  • when I hit 'Save' for the 2nd time, the record is saved but uploaded files are missing
  • when I go to edit, the upload procedure works as expected

Expected result:

  • the progress bar should indicate the upload load
  • preview of the file should be visible immediately
  • when I hit 'Save' for the first time, I should see the preview of the added record.

The browser console doesn't return any error.

Tested on latest. To reproduce go for example to Products > Price Book > Enterprises and SMBs (standard price book) and add a new record

@zmija zmija added the Type: Bug Something isn't working label May 23, 2019
@tjerman
Copy link
Member

tjerman commented Jun 28, 2019

@darh this happens, because it tries to upload the file to the given recordID, that doesn't yet exist.
We could fix this by either:

  • creating a new record when "add record button" is pressed
  • upload files to a temporary location with a specified ttl to avoid junk
  • when creating new record, files get uploaded only after the save button is pressed.

I would go for 2 or 3. What do you think?

@darh darh changed the title Fille upload issue File upload issue Jul 1, 2019
@darh darh self-assigned this Jul 2, 2019
@darh
Copy link
Contributor

darh commented Jul 2, 2019

We'll disable uploading w/o record for now. See cortezaproject/corteza#3.

@darh
Copy link
Contributor

darh commented Jul 15, 2019

Fixed.

@darh darh closed this as completed Jul 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants