Fix compose memory leak

cortezaproject · Aug 18, 2023 · 95cf245 · 95cf245
1 parent b96ea0e
commit 95cf245
Show file tree

Hide file tree

Showing 76 changed files with 869 additions and 33 deletions.
diff --git a/client/web/compose/src/components/Admin/Module/DalSettings.vue b/client/web/compose/src/components/Admin/Module/DalSettings.vue
@@ -195,6 +195,10 @@ export default {
     this.fetchConnections()
   },
 
+  beforeDestroy () {
+    this.setDefaultValues()
+  },
+
   methods: {
     async fetchConnections () {
       this.processing = true
@@ -263,6 +267,17 @@ export default {
     getOptionKey ({ connectionID }) {
       return connectionID
     },
+
+    setDefaultValues () {
+      this.processing = false
+      this.connections = []
+      this.moduleFields = []
+      this.moduleFieldEncoding = []
+      this.selectedGroup = ''
+      this.systemFields = []
+      this.systemFieldEncoding = []
+      this.optionsGroups = []
+    },
   },
 }
 </script>
diff --git a/client/web/compose/src/components/Admin/Module/DiscoverySettings.vue b/client/web/compose/src/components/Admin/Module/DiscoverySettings.vue
@@ -153,13 +153,18 @@ export default {
               const fields = [...existingFields].map(name => this.module.fields.find(field => field.name === name))
 
               this[value].result.push({ lang, fields })
+              existingFields.clear()
             })
           })
         }
       },
     },
   },
 
+  beforeDestroy () {
+    this.setDefaultValues()
+  },
+
   methods: {
     onSave () {
       const discovery = {
@@ -182,6 +187,14 @@ export default {
         discovery,
       })
     },
+
+    setDefaultValues () {
+      this.public = {}
+      this.private = {}
+      this.protected = {}
+      this.currentTabIndex = 0
+      this.currentLang = undefined
+    },
   },
 }
 </script>

diff --git a/client/web/compose/src/components/Admin/Module/FederationSettings.vue b/client/web/compose/src/components/Admin/Module/FederationSettings.vue
@@ -295,7 +295,6 @@ export default {
   },
 
   computed: {
-
     //
     // shared modules
     //
@@ -382,6 +381,10 @@ export default {
     this.preload()
   },
 
+  beforeDestroy () {
+    this.setDefaultValues()
+  },
+
   methods: {
     async preload () {
       await this.$FederationAPI.nodeSearch({ status: 'paired' })
@@ -732,6 +735,19 @@ export default {
 
       this.moduleMappings[nodeID] = mm
     },
+
+    setDefaultValues () {
+      this.showModal = false
+      this.servers = []
+      this.moduleFields = []
+      this.sharedModule = null
+      this.sharedModules = {}
+      this.sharedModulesMapped = {}
+      this.exposedModules = {}
+      this.moduleMappings = {}
+      this.downstream = {}
+      this.upstream = {}
+    },
   },
 }
 </script>

diff --git a/client/web/compose/src/components/Admin/Module/Records/ColumnPicker.vue b/client/web/compose/src/components/Admin/Module/Records/ColumnPicker.vue
@@ -68,10 +68,18 @@ export default {
     })
   },
 
+  beforeDestroy () {
+    this.setDefaultValues()
+  },
+
   methods: {
     onSave () {
       this.$emit('updateFields', this.filteredFields)
     },
+
+    setDefaultValues () {
+      this.filteredFields = []
+    },
   },
 }
 </script>

diff --git a/client/web/compose/src/components/Admin/Page/Builder/Selector.vue b/client/web/compose/src/components/Admin/Page/Builder/Selector.vue
@@ -222,6 +222,10 @@ export default {
     }
   },
 
+  beforeDestroy () {
+    this.setDefaultValues()
+  },
+
   methods: {
     isOptionDisabled (type) {
       return (!this.recordPage && type.recordPageOnly) || this.disabledKinds.includes(type.block.kind)
@@ -230,6 +234,12 @@ export default {
     getBlockLabel ({ title, kind }) {
       return title || kind
     },
+
+    setDefaultValues () {
+      this.current = undefined
+      this.selectedExistingBlock = undefined
+      this.types = []
+    },
   },
 }
 </script>
diff --git a/client/web/compose/src/components/Chart/Report/GenericChart.vue b/client/web/compose/src/components/Chart/Report/GenericChart.vue
@@ -519,6 +519,10 @@ export default {
     }
   },
 
+  beforeDestroy () {
+    this.setDefaultValues()
+  },
+
   methods: {
     hasRelativeDisplay: compose.chartUtil.hasRelativeDisplay,
 
@@ -536,6 +540,15 @@ export default {
     chartTypeChanged (metric) {
       metric.relativeValue = false
     },
+
+    setDefaultValues () {
+      this.chartTypes = []
+      this.legendPositions = []
+      this.axisLabelPositions = []
+      this.tensionSteps = []
+      this.lineStyleOptions = []
+      this.scatterSymbolOptions = []
+    },
   },
 }
 </script>

diff --git a/client/web/compose/src/components/Chart/Report/ReportEdit.vue b/client/web/compose/src/components/Chart/Report/ReportEdit.vue
@@ -639,6 +639,10 @@ export default {
     },
   },
 
+  beforeDestroy () {
+    this.setDefaultValues()
+  },
+
   methods: {
     hasRelativeDisplay: compose.chartUtil.hasRelativeDisplay,
 
@@ -675,6 +679,14 @@ export default {
     isTemporalField (name) {
       return this.dimensionFields.some(f => f.value === name && f.kind === 'DateTime')
     },
+
+    setDefaultValues () {
+      this.metricAggregates = []
+      this.dimensionModifiers = []
+      this.predefinedFilters = []
+      this.alignments = []
+      this.orientations = []
+    },
   },
 }
 </script>
diff --git a/client/web/compose/src/components/Common/Grid.vue b/client/web/compose/src/components/Common/Grid.vue
@@ -146,7 +146,8 @@ export default {
   },
 
   beforeDestroy () {
-    window.removeEventListener('resize', this.windowResizeThrottledHandler)
+    this.setDefaultValues()
+    this.destroyEvents()
   },
 
   methods: {
@@ -167,6 +168,15 @@ export default {
         ({ x, y, w, h, i }) => new compose.PageBlockMaker({ ...this.blocks[i], xywh: [x, y, w, h] }),
       ))
     },
+
+    setDefaultValues () {
+      this.layout = []
+      this.boundingRects = []
+    },
+
+    destroyEvents () {
+      window.removeEventListener('resize', this.windowResizeThrottledHandler)
+    },
   },
 }
 </script>

diff --git a/client/web/compose/src/components/Common/RecordListFilter.vue b/client/web/compose/src/components/Common/RecordListFilter.vue
@@ -353,6 +353,10 @@ export default {
     },
   },
 
+  beforeDestroy () {
+    this.setDefaultValues()
+  },
+
   created () {
     // Change all module fields to single value to keep multi value fields and single value
     const module = JSON.parse(JSON.stringify(this.module || {}))
@@ -658,6 +662,13 @@ export default {
     getOptionKey ({ name }) {
       return name
     },
+
+    setDefaultValues () {
+      this.componentFilter = []
+      this.conditions = []
+      this.mock = {}
+      this.preventPopoverClose = false
+    },
   },
 }
 </script>

diff --git a/client/web/compose/src/components/ModuleFields/Configurator/Number.vue b/client/web/compose/src/components/ModuleFields/Configurator/Number.vue
@@ -399,6 +399,10 @@ export default {
     this.liveExample = this.field.options.display === 'number' ? 123.45679 : 33.45679
   },
 
+  beforeDestroy () {
+    this.setDefaultValues()
+  },
+
   methods: {
     addThreshold () {
       this.field.options.thresholds.push({ value: 0, variant: 'success' })
@@ -409,6 +413,13 @@ export default {
         this.field.options.thresholds.splice(index, 1)
       }
     },
+
+    setDefaultValues () {
+      this.liveExample = undefined
+      this.displayOptions = []
+      this.variants = []
+      this.mock = {}
+    },
   },
 }
 </script>
diff --git a/client/web/compose/src/components/ModuleFields/Configurator/Record.vue b/client/web/compose/src/components/ModuleFields/Configurator/Record.vue
@@ -109,7 +109,6 @@ export default {
 
   data () {
     return {
-      selected: null,
       selectOptions: [
         { text: this.$t('kind.select.optionType.default'), value: 'default', allowDuplicates: true },
         { text: this.$t('kind.select.optionType.multiple'), value: 'multiple' },

diff --git a/client/web/compose/src/components/ModuleFields/Configurator/Select.vue b/client/web/compose/src/components/ModuleFields/Configurator/Select.vue
@@ -219,6 +219,10 @@ export default {
     }
   },
 
+  beforeDestroy () {
+    this.setDefaultValues()
+  },
+
   methods: {
     handleAddOption () {
       this.f.options.options.push({
@@ -234,6 +238,11 @@ export default {
         this.f.options.isUniqueMultiValue = true
       }
     },
+
+    setDefaultValues () {
+      this.newOption = {}
+      this.options = []
+    },
   },
 }
 </script>
diff --git a/client/web/compose/src/components/ModuleFields/Configurator/User.vue b/client/web/compose/src/components/ModuleFields/Configurator/User.vue
@@ -93,6 +93,10 @@ export default {
     })
   },
 
+  beforeDestroy () {
+    this.setDefaultValues()
+  },
+
   methods: {
     getOptionKey ({ roleID }) {
       return roleID
@@ -104,6 +108,11 @@ export default {
         this.f.options.isUniqueMultiValue = true
       }
     },
+
+    setDefaultValues () {
+      this.selectOptions = []
+      this.roleOptions = []
+    },
   },
 }
 </script>
diff --git a/client/web/compose/src/components/ModuleFields/Editor/Geometry.vue b/client/web/compose/src/components/ModuleFields/Editor/Geometry.vue
@@ -298,6 +298,10 @@ export default {
     }
   },
 
+  beforeDestroy () {
+    this.setDefaultValues()
+  },
+
   methods: {
     openMap (index) {
       this.localValueIndex = index
@@ -421,6 +425,13 @@ export default {
         this.toastErrorHandler(this.$t('notification:field-geometry.geolocationErrors.locationSearchFailed'))()
       })
     },
+
+    setDefaultValues () {
+      this.localValue = undefined
+      this.localValueIndex = undefined
+      this.map = {}
+      this.geoSearch = {}
+    },
   },
 }
 </script>
diff --git a/client/web/compose/src/components/ModuleFields/Editor/Record.vue b/client/web/compose/src/components/ModuleFields/Editor/Record.vue
@@ -296,6 +296,10 @@ export default {
     }
   },
 
+  beforeDestroy () {
+    this.setDefaultValues()
+  },
+
   methods: {
     ...mapActions({
       findModuleByID: 'module/findByID',
@@ -465,6 +469,7 @@ export default {
             }
 
             mappedIDs[r.recordID] = relatedRecordValue.join(relatedLabelField.options.multiDelimiter)
+            relatedRecordIDs.clear()
           }
         } else if (relatedField.kind === 'User') {
           this.processing = true
@@ -515,6 +520,14 @@ export default {
     getOptionKey ({ value }) {
       return value
     },
+
+    setDefaultValues () {
+      this.processing = false
+      this.query = ''
+      this.records = []
+      this.recordValues = {}
+      this.filter = {}
+    },
   },
 }
 </script>