Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix record selector, metric, chart values not refreshed when inline and bulk edit changes are applied to related records #1435

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Fix record selector, metric, chart values not refreshed when inline and bulk edit changes are applied to related records #1435

merged 2 commits into from
Oct 30, 2023

Conversation

kelanik8
Copy link
Contributor

The following changes are implemented

TODO: Summary

Changes in the user interface:

TODO: Add screenshots, recordings or remove this section

Checklist when submitting a final (!draft) PR

  • Commits are tidied up, squashed if needed and follow guidelines in CONTRIBUTING.md
  • Code builds
  • All existing tests pass
  • All new critical code is covered by tests
  • PR is linked to the relevant issue(s)
  • Rebased with the target branch

@kelanik8 kelanik8 requested a review from Fajfa September 12, 2023 12:01
@kelanik8 kelanik8 self-assigned this Sep 12, 2023
@kelanik8 kelanik8 linked an issue Sep 12, 2023 that may be closed by this pull request
Record selector value not refreshed when related record value is updated and on the same page #1208
Closed
Fajfa
Fajfa requested changes Sep 13, 2023
View reviewed changes
client/web/compose/src/components/ModuleFields/Viewer/Record.vue Outdated Show resolved Hide resolved
client/web/compose/src/components/ModuleFields/Viewer/Record.vue Outdated Show resolved Hide resolved
client/web/compose/src/store/record.js Outdated Show resolved Hide resolved
client/web/compose/src/mixins/record.js Outdated Show resolved Hide resolved
client/web/compose/src/components/PageBlocks/RecordListBase.vue Outdated Show resolved Hide resolved
@kelanik8 kelanik8 force-pushed the 2023.3.x-fix-record-selector-not-refreshed branch from c8d0f16 to 3b62ef7 Compare September 14, 2023 22:26
Fajfa
Fajfa requested changes Sep 15, 2023
View reviewed changes
Copy link
Member

@Fajfa Fajfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. All blocks that use fetchRecords (resolve), should be refreshed when a related record (with the same moduleID) is updated. If you could please check if there is any other page blocks that need this (record organizer does for example)
  2. For some reason the record list refreshes twice when using bulk record edit. Guessing the saving and the emited event triggers the refresh

client/web/compose/src/components/ModuleFields/Viewer/Record.vue Outdated Show resolved Hide resolved
client/web/compose/src/store/record.js Outdated Show resolved Hide resolved
Fajfa
Fajfa approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@Fajfa Fajfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems good to me, maybe some comments on the bits with more code, so we know why it's there.

Fajfa
Fajfa requested changes Sep 19, 2023
View reviewed changes
Copy link
Member

@Fajfa Fajfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The double fetch still happens

@kelanik8 kelanik8 force-pushed the 2023.3.x-fix-record-selector-not-refreshed branch from b951369 to bda42b5 Compare September 20, 2023 10:41
@Fajfa Fajfa force-pushed the 2023.3.x-fix-record-selector-not-refreshed branch from bda42b5 to c1b4c3d Compare September 21, 2023 13:35
@kelanik8 kelanik8 force-pushed the 2023.3.x-fix-record-selector-not-refreshed branch from c1b4c3d to 4217a14 Compare September 21, 2023 13:40
@Fajfa Fajfa force-pushed the 2023.3.x-fix-record-selector-not-refreshed branch from 4217a14 to 4378189 Compare September 28, 2023 11:52
@kelanik8 kelanik8 force-pushed the 2023.3.x-fix-record-selector-not-refreshed branch from 4378189 to 573870b Compare October 5, 2023 14:00
@katrinDY
Copy link
Contributor

katrinDY commented Oct 5, 2023 •
edited
Loading

  • if I have two comment blocks with the same config and add a comment in one, the other comment block isn't updated. I also have a RL pointing to the same module as the comment blocks and it's not updated after a comment was added

Other pbs I think we should update after a change has been made in a RL: (Discuss with Jože how to proceed)

  • calendar
  • record revision
  • report - will not be addressed because it's not connected to an external moduleID
  • progress bar
  • geometry

Fajfa
Fajfa approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@Fajfa Fajfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, looks good to me

@kelanik8 kelanik8 changed the base branch from 2023.3.x to 2023.9.x October 19, 2023 11:10
@kelanik8 kelanik8 force-pushed the 2023.3.x-fix-record-selector-not-refreshed branch from 38e241c to 4740e20 Compare October 19, 2023 11:10
@katrinDY
Copy link
Contributor

katrinDY commented Oct 23, 2023 •
edited
Loading

  • RL isn't updated after a record has been added through the save as copy button from a modal => no longer an issue
  • loading time has increased a lot when trying to add a record through a modal
    3

@kelanik8 kelanik8 force-pushed the 2023.3.x-fix-record-selector-not-refreshed branch from 4740e20 to 348162f Compare October 27, 2023 11:14
@katrinDY
Copy link
Contributor

Loading time is fine. My bad

@kelanik8 kelanik8 force-pushed the 2023.3.x-fix-record-selector-not-refreshed branch from 348162f to 1ead204 Compare October 30, 2023 08:56
@kelanik8 kelanik8 force-pushed the 2023.3.x-fix-record-selector-not-refreshed branch from 1ead204 to 35d455f Compare October 30, 2023 10:18
@kelanik8 kelanik8 merged commit 35d455f into 2023.9.x Oct 30, 2023
1 check passed
@kelanik8 kelanik8 deleted the 2023.3.x-fix-record-selector-not-refreshed branch October 30, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fajfa Fajfa Fajfa approved these changes

Assignees

@kelanik8 kelanik8

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Record selector value not refreshed when related record value is updated and on the same page
3 participants
@kelanik8 @katrinDY @Fajfa