Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin panel/page tree: incorrect state of pages on loading #623

Closed
1 task done
katrinDY opened this issue Dec 9, 2022 · 3 comments · Fixed by #671
Closed
1 task done

Admin panel/page tree: incorrect state of pages on loading #623

katrinDY opened this issue Dec 9, 2022 · 3 comments · Fixed by #671
Assignees
@katrinDY
Labels
bug Something isn't working frontend Frontend code changes (Javascript, Typescript, Vue.js) trivial Trivial issue that do not require major changes
Milestone
2022.9.5

Comments

@katrinDY
Copy link
Contributor

katrinDY commented Dec 9, 2022 •
edited

Description

While the pages are being fetched instead of showing the loading text and spinner, No pages is shown

Current behaviour

Image

TODO

  • show spinner on loading

PR

#671
@katrinDY katrinDY added bug Something isn't working frontend Frontend code changes (Javascript, Typescript, Vue.js) trivial Trivial issue that do not require major changes labels Dec 9, 2022
@katrinDY katrinDY self-assigned this Dec 12, 2022
@katrinDY katrinDY linked a pull request Dec 16, 2022 that will close this issue
Show loading spinner before displaying the page tree content #671
Merged
@katrinDY katrinDY added this to the 2022.9.5 milestone Dec 19, 2022
@katrinDY
Copy link
Contributor Author

CL:

Fixed

What: The state of the page list while its content is being fetched.

How: A spinner with "Loading" text was added. After the content is fetched, the spinner is hidden.

@Bojan-Svirkov
Copy link
Contributor

CL has been added and this has been tested, but there is just a little thing that needs to be fixed:

image

@katrinDY
Copy link
Contributor Author

Issues addressed. Code for
22.9
23.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@katrinDY katrinDY

Labels
bug Something isn't working frontend Frontend code changes (Javascript, Typescript, Vue.js) trivial Trivial issue that do not require major changes
Projects
None yet
Milestone
2022.9.5
Development

Successfully merging a pull request may close this issue.

Show loading spinner before displaying the page tree content cortezaproject/corteza
2 participants
@Bojan-Svirkov @katrinDY