Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve language dropdown menu #38

Closed
cory2067 opened this issue Mar 3, 2022 · 1 comment · Fixed by #66
Closed

Improve language dropdown menu #38

cory2067 opened this issue Mar 3, 2022 · 1 comment · Fixed by #66
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers high pri Should get done as soon as possible

Comments

@cory2067
Copy link
Owner

cory2067 commented Mar 3, 2022

image
This is pretty gross. Instead, we should have these options change based on which tourney is currently being viewed.

The code for this is in Navbar.js, where there's a hardcoded list of language options.
Maybe we could populate the list of available languages based off what files are in the client/src/content directory

@cory2067 cory2067 added enhancement New feature or request good first issue Good for newcomers labels Mar 3, 2022
@Briesmas
Copy link
Collaborator

Briesmas commented Mar 4, 2022

I'd like to add something to this.
Change the "Language" on the top menu to a more recognizable term/icon by everyone. Some ppl don't seem to know this word. I believe either displaying the current selected language (English, ...) or a flag (like osu! website) would make it clearer.

@cory2067 cory2067 added the high pri Should get done as soon as possible label Mar 7, 2022
@cory2067 cory2067 self-assigned this Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers high pri Should get done as soon as possible
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants