Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue with mu, cosine of zenith, in absorption and radiation calculation from disk #16

Closed
cosimoNigro opened this issue May 14, 2020 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@cosimoNigro
Copy link
Owner

The range of mu used for integration changes with the position of the blob above the BH (r) according to

 mu_min = 1 / sqrt(1 + (R_out / r)^2)
 mu_max = 1 / sqrt(1 + (R_in / r)^2)

In the absorption though an array of mu calculated at a single r (the one occupied by the blob) is used
https://github.com/cosimoNigro/agnpy/blob/master/agnpy/absorption.py#L97
when integrating from r to infinity for the optical depth, the array of mu has to be recomputed at each value of r and updated.

For the same reason the same problem might occur in the photon density:
https://github.com/cosimoNigro/agnpy/blob/master/agnpy/targets.py#L202

The integration has to be separated somehow, I'll take care of that.

@cosimoNigro cosimoNigro self-assigned this May 14, 2020
@cosimoNigro cosimoNigro added the bug Something isn't working label May 14, 2020
@cosimoNigro
Copy link
Owner Author

The integration is now properly performed by changing the extreme of integrations in mu at each distance.
Taken care by PR #46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant