Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple line titleLabel #32

Closed
cohix opened this issue Sep 7, 2015 · 11 comments
Closed

Multiple line titleLabel #32

cohix opened this issue Sep 7, 2015 · 11 comments
Milestone

Comments

@cohix
Copy link

cohix commented Sep 7, 2015

I would like the option to enable multi-line titles. Something like this:

card.titleLabel!.lineBreakMode = NSLineBreakMode.ByWordWrapping
card.titleLabel!.numberOfLines = 0

could allow the title to be multi-line with the card resizing appropriately.

Thank you for the amazing library!

@adamdahan
Copy link
Contributor

@cohix That's a good suggestion :) Thanks for the feedback - perhaps in the next few versions we will support that for all our cards.

@cohix
Copy link
Author

cohix commented Sep 7, 2015

Thank you!

@cohix
Copy link
Author

cohix commented Sep 8, 2015

@adamdahan I see that you added some relevant code in the 1.12.0 release.. has this feature been fully implemented? If so, what is the process for enabling multi-line titles?

Cheers

@daniel-jonathan
Copy link
Member

@cohix The added code in 1.12.0 is to support the manipulation of autolayout within the card. The limitation of the multiline support is the height restriction on the tittleLabel property. The feature you are looking for is being discussed in 1.13.0.

@cohix
Copy link
Author

cohix commented Sep 8, 2015

Great, thank you! Godspeed 😄

@cohix
Copy link
Author

cohix commented Sep 8, 2015

@adamdahan @DanielDahan I needed this asap so I decided to implement it myself. I've finished it and tested. Would you be interested in a PR? See my fork.

p.s. I more or less copied the implementation from the detail label 😜

@adamdahan
Copy link
Contributor

@cohix go for it :)

@cohix
Copy link
Author

cohix commented Sep 8, 2015

It's only for BasicCardView thus far. I think I'll wait until I'm done with ImageCardView as well. @adamdahan

@adamdahan
Copy link
Contributor

@cohix 👍 make sure you pr against the dev branch

@adamdahan adamdahan reopened this Sep 8, 2015
@adamdahan
Copy link
Contributor

@DanielDahan reopening ticket

@daniel-jonathan
Copy link
Member

@cohix This is now fixed in issue-41, which I am pushing as a PR to development. Once merged you can use the development branch if you would like to utilize the feature prior to 1.13

@daniel-jonathan daniel-jonathan added this to the 1.13.0 milestone Sep 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants