Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lldb in MaterialButton #47

Closed
cohix opened this issue Sep 18, 2015 · 14 comments
Closed

lldb in MaterialButton #47

cohix opened this issue Sep 18, 2015 · 14 comments

Comments

@cohix
Copy link

cohix commented Sep 18, 2015

Bug in MaterialButton in this block:

private func prepareBackgroundColorView() {
        backgroundColorView.translatesAutoresizingMaskIntoConstraints = false
        backgroundColorView.layer.masksToBounds = true
        backgroundColorView.clipsToBounds = true
        backgroundColorView.userInteractionEnabled = false
        insertSubview(backgroundColorView, atIndex: 0)
        Layout.expandToParent(self, child: backgroundColorView)
    }

Where the insertSubview line fails with lldb

@cohix
Copy link
Author

cohix commented Sep 18, 2015

I may have resolved by just adding self. to the offending line. Will keep testing.

Issue was intermittent to start, stack trace gave me little to no info.

@daniel-jonathan
Copy link
Member

Okay, are you testing 1.12, or dev?


Daniel Dahan

M: +1 647.627.0770
Skype: djondahan

On Sep 18, 2015, at 2:21 PM, Connor Hicks notifications@github.com wrote:

I may have resolved by just adding self. to the offending line. Will keep testing.

Issue was intermittent to start, stack trace gave me little to no info.


Reply to this email directly or view it on GitHub #47 (comment).

@cohix
Copy link
Author

cohix commented Sep 18, 2015

I'm actually using the issue-44 branch that no longer exists because it was
the
only one that would compile on Xcode 7. Tell me which branch to test and
I'll do
so.

@daniel-jonathan
Copy link
Member

I merged issue-44 into dev. That should work fine. I haven’t done much to it since the merge. Tonight and this weekend we will be going through it to make sure it is iOS 9 ready. We have an app that will be sent to Apple as well that will confirm all is okay.


Daniel Dahan

M: +1 647.627.0770
Skype: djondahan

On Sep 18, 2015, at 2:26 PM, Connor Hicks notifications@github.com wrote:

I'm actually using the issue-44 branch that no longer exists because it was
the
only one that would compile on Xcode 7. Tell me which branch to test and
I'll do
so.

Reply to this email directly or view it on GitHub #47 (comment).

@cohix
Copy link
Author

cohix commented Sep 18, 2015

Sounds good, I'll test on dev branch starting Monday.

@cohix
Copy link
Author

cohix commented Sep 22, 2015

@DanielDahan I still get the lldb error on the development branch.

I did however get an update approved using MK cards so cheers :)

@daniel-jonathan
Copy link
Member

Can you copy and paste the error message?


Daniel Dahan

M: +1 647.627.0770
Skype: djondahan

On Sep 22, 2015, at 11:53 AM, Connor Hicks notifications@github.com wrote:

@DanielDahan https://github.com/danieldahan I still get the lldb error on the development branch.


Reply to this email directly or view it on GitHub #47 (comment).

@cohix
Copy link
Author

cohix commented Sep 22, 2015

(lldb)

Thread 20: breakpoint 1.1

Nothing else is given.

@daniel-jonathan
Copy link
Member

So what I need your help in doing, is to give as much context to the issue, because I am not able to reproduce it. Any additional information would be great. Also, do a latest pull of dev.


Daniel Dahan

M: +1 647.627.0770
Skype: djondahan

On Sep 22, 2015, at 12:03 PM, Connor Hicks notifications@github.com wrote:

(lldb)

Thread 20: breakpoint 1.1

Nothing else is given.


Reply to this email directly or view it on GitHub #47 (comment).

@cohix
Copy link
Author

cohix commented Sep 22, 2015

Honestly I can't figure it out either. I've been trying to debug it all morning. The error is not consistently thrown, and although it causes the app to crash while connected to Xcode, I cannot seem to make the app crash when disconnected. Nothing other than the button itself is show in the scope, and everything inside the button looks fine.

@daniel-jonathan
Copy link
Member

Can you post the code for adding the button and such?


Daniel Dahan

M: +1 647.627.0770
Skype: djondahan

On Sep 22, 2015, at 12:21 PM, Connor Hicks notifications@github.com wrote:

Honestly I can't figure it out either. I've been trying to debug it all morning. The error is not consistently thrown, and although it causes the app to crash while connected to Xcode, I cannot seem to make the app crash when disconnected. Nothing other than the button itself is show in the scope, and everything inside the button looks fine.


Reply to this email directly or view it on GitHub #47 (comment).

@daniel-jonathan
Copy link
Member

@cohix any luck with this?

@cohix
Copy link
Author

cohix commented Sep 23, 2015

No, none. You can close the issue if you'd like. I submitted an update
using the
development branch. As far as I can tell the issue only happens when
conmected
to Xcode so we'll see if it gets approved.

@daniel-jonathan
Copy link
Member

Thanks :) Keep us posted. We are submitting an app on Sunday with MaterialKit and will see if any issues arise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants