-
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicate keys throw an error with an unhelpful message #48
Comments
@davidtheclark what's blocking me from fixing this is the tests failing from a clean state on master when I clone and run I noticed that node v0.12 support was added recently even though the LTS support dropped as of December. Are there plans to move forward again?
|
@JaKXz How are the tests failing? What is the error? Have you tried seeing if the tests pass on Travis with Node 7 (by changing the I just tried
As specified in the
It was re-added, because we removed support but then some users wanted it back, and it was easy to restore.
I don't understand "move forward" here. There shouldn't be a problem with higher versions of Node. Maybe your error message will clarify things.
I disagree. I'd rather have the codebase stick to one feature set than write the tests differently than the rest of the code. |
@davidtheclark the failures are here: https://travis-ci.org/davidtheclark/cosmiconfig/jobs/189389524 I had spent some time a few weeks ago attempting to debug the failures locally but made no progress without context. I suppose I'll make a separate issue about the tests failing on node v7 (done: #53). re:
using |
You have to name the variable |
I've been meaning to give |
@JaKXz If you'd like to try, sure! It will be much more effort, though, since the syntax is more different from AVA's and the way of handling mocks will need to change. If that's the kind of challenge you seek, go for it. |
Closing as stale, and probably out of scope for this package. |
I am working on stylelint webpack plugin and I think it would be appropriate for stylelint itself to inform users that they have duplicate keys in their
.stylelintrc
. I have been trying to get a PR going but I haven't had success running the tests on master yet.Raising the issue here because I don't think that it's difficult to fix but I'm kinda blocked right now.
The text was updated successfully, but these errors were encountered: