Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change ChainRegistry types to snake_case to match chain-registry #12

Open
pyramation opened this issue Sep 19, 2022 · 0 comments
Open

Comments

@pyramation
Copy link
Contributor

Do you think the ChainRegistry class should match the casing of cosmos chain-registry and keep consistent, and use snake_case for fields or should use use camelCase?

The argument for snake_case (which is not the current case we use for ChainRegistry) is for keeping consistent with the JSON objects that are inside of the chain-registry.

Basically we currently have this for ChainRegistry

export declare class ChainRegistry {
    assetLists: AssetList[];
    chains: Chain[];
    ibcData: IBCInfo[];
}

However, the AssetList, Chain, and all else is using snake_case

The issue if we do adopt snake_case is that when we implement classes, it may be weird to have mixed case.

Curious your thoughts here @liujun93

@pyramation pyramation changed the title ChainRegistry types and naming convention change ChainRegistry types to snake_case to match chain-registry Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant