Reduce load on Cilium API by filtering more events #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The allocation events from Nomad include the NodeID where the allocation is assigned. We can use that to drop events early in processing by comparing the event NodeID with the local agent NodeID. This reduces the load on Cilium agents in the cluster as they are no longer queried about allocations that don't exist on the node. Additionally we only need to watch the `Allocation` event stream and can ignore events for terminal allocations. Nomad will handle cleaning up the endpoint in that case.
Reduce the load on the Cilium API further by not patching the endpoint with labels when they haven't changed. This should cut down on endpoint regeneration times and reduce the chance of hitting API rate limits.
✅ Deploy Preview for netreap canceled.
|
protochron
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature reduces the API call rate to Cilium and tries to ensure netreap only makes calls when needed. This helps in high density scenarios to reduce the CIlium agent API overhead. This feature consists of three main changes:
Allocationevent stream and can ignore events for terminal allocations. Nomad will handle cleaning up the endpoint in that case.