Skip to content
This repository has been archived by the owner on Oct 20, 2021. It is now read-only.

feat(Pager): add Pager component #46

Merged
merged 1 commit into from
Apr 10, 2019
Merged

feat(Pager): add Pager component #46

merged 1 commit into from
Apr 10, 2019

Conversation

Kimi-Gao
Copy link
Member

@Kimi-Gao Kimi-Gao commented Apr 7, 2019 •
edited

  • Make sure that you propose PR to right branch: bugfix for master, feature for latest active branch feature-x.x.
  • Make sure that you follow earth-ui's code convention.
  • Add some descriptions and refer relative issues(optional) for your PR.
  • Add Assignees(assign yourself mostly) for your PR.
  • Add Labels for your PR.

Extra checklist:

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Add unit tests for the feature.

Description:

  • support basic Pager

Gif:
Pager

@Kimi-Gao Kimi-Gao added the PR: feat A new feature label Apr 7, 2019
@Kimi-Gao Kimi-Gao self-assigned this Apr 7, 2019
@Kimi-Gao Kimi-Gao changed the base branch from master to feature-0.5 April 7, 2019 09:10
@Kimi-Gao Kimi-Gao added this to the earth-ui@0.5.x milestone Apr 7, 2019
@Kimi-Gao Kimi-Gao merged commit 74216ec into feature-0.5 Apr 10, 2019
@Kimi-Gao Kimi-Gao deleted the pager branch April 10, 2019 08:23
@Kimi-Gao Kimi-Gao added this to In progress in earth-ui@0.5.x via automation Apr 10, 2019
@Kimi-Gao Kimi-Gao moved this from In progress to Reviewer approved in earth-ui@0.5.x Apr 10, 2019
@Kimi-Gao Kimi-Gao moved this from Reviewer approved to Done in earth-ui@0.5.x Apr 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@goroyal goroyal goroyal approved these changes

@ice418 ice418 Awaiting requested review from ice418

@weiyuxuan weiyuxuan Awaiting requested review from weiyuxuan

Assignees

@Kimi-Gao Kimi-Gao

Labels
PR: feat A new feature
Projects
No open projects
earth-ui@0.5.x
  
Done
Milestone
earth-ui@0.5.x
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Kimi-Gao @goroyal