Skip to content
This repository has been archived by the owner on Oct 20, 2021. It is now read-only.

[Button] Refactor button and add gallery #70

Closed
3 of 4 tasks
Kimi-Gao opened this issue Sep 11, 2019 · 0 comments · Fixed by #78
Closed
3 of 4 tasks

[Button] Refactor button and add gallery #70

Kimi-Gao opened this issue Sep 11, 2019 · 0 comments · Fixed by #78
Assignees
@Kimi-Gao
Labels
type: task
Projects
earth-ui@0.7.x
Milestone
earth-ui@0.7.x

Comments

@Kimi-Gao
Copy link
Member

Kimi-Gao commented Sep 11, 2019 •
edited

Refactor

Discussion

  • which type is the default button?
  • need focus?
  • remove secondary button?
  • link button underline?

Improve

  • icon + link button style issue
  • use small replace micro

Gallery

Switch background-color: white / blue
Switch icon

  • Standard
  • Focus?
  • Hover
  • Disabled

Others

  • test coverage > 90%
  • use react hooks
@Kimi-Gao Kimi-Gao added this to the earth-ui@0.6.x milestone Sep 14, 2019
@Kimi-Gao Kimi-Gao added this to To do in earth-ui@0.6.x Sep 20, 2019
@Kimi-Gao Kimi-Gao self-assigned this Sep 20, 2019
@Kimi-Gao Kimi-Gao removed this from To do in earth-ui@0.6.x Sep 30, 2019
@Kimi-Gao Kimi-Gao added this to To do in earth-ui@0.7.x Oct 1, 2019
@Kimi-Gao Kimi-Gao moved this from To do to In progress (issues) in earth-ui@0.7.x Oct 2, 2019
@Kimi-Gao Kimi-Gao mentioned this issue Oct 3, 2019
Merged
8 tasks
earth-ui@0.7.x automation moved this from In progress (issues) to Done (issues) Jan 14, 2020
@Kimi-Gao Kimi-Gao linked a pull request Feb 10, 2020 that will close this issue
refactor(Button): refactor button and add gallery #78
Merged
8 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Kimi-Gao Kimi-Gao

Labels
type: task
Projects
No open projects
earth-ui@0.7.x
  
Done (issues)
Milestone
earth-ui@0.7.x
Development

Successfully merging a pull request may close this issue.

refactor(Button): refactor button and add gallery webapp-suite/ui
1 participant
@Kimi-Gao